https://bugzilla.redhat.com/show_bug.cgi?id=1902102 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks very much for the review Andy, (In reply to Andy Mender from comment #1) > Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56322556 > > > URL: https://github.com/alejoe91/%{pretty_name}/ > > Minor thing, but for the URL you can use %{pypi_name}. It will still reach > it. Thanks, noted. I've just left it there to match the case used in the PyPi page. > > > %if %{with tests} > > BuildRequires: %{py3_dist pytest} > > BuildRequires: %{py3_dist numpy} > > BuildRequires: %{py3_dist pyyaml} > > BuildRequires: %{py3_dist matplotlib} > > %endif > > Python dependencies should be declared using the format "python3dist(foo)". The %{py3_dist ...} macro expands to the canonical form: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_requires_and_buildrequires_with_standardized_names > > > %package doc > > Summary: %{summary} > > BuildRequires: %{py3_dist ipython} > > BuildRequires: %{py3_dist sphinx} > > BuildRequires: %{py3_dist sphinx-rtd-theme} > > BuildRequires: %{py3_dist numpy} > > Not a hard requirement, but would it make sense to add a Requires on > python3-%{pypi_name} to the -doc subpackage? I've removed the docs sub-package entirely and referred to the online documentation. It's not worth the work to unbundle the fonts and then monitor changes in it for each update. > > > # Comment out to remove /usr/bin/env shebangs > > # Can use something similar to correct/remove /usr/bin/python shebangs also > > # find . -type f -name "*.py" -exec sed -i '/^#![ ]*\/usr\/bin\/env.*$/ d' {} 2>/dev/null ';' > > I guess this part should be re-enabled, right? It wasn't needed in this package (rpmlint reports it), removed. > > PYTHONPATH=./ sphinx-build-%{python3_version} docs/source docs/build/ > > rm -rf docs/build/{.doctrees,.buildinfo} -vf > > From fedora-review: > > [!]: Avoid bundling fonts in non-fonts packages. > > Note: Package contains font files > > You might need to do some font unbundling if the Sphinx docs bundle font > files. > Below SPEC file I'm currently updating does this very extensively: > https://src.fedoraproject.org/rpms/widelands/raw/master/f/widelands.spec Removed docs and referred to the online documentation. > > > %check > > %if %{with tests} > > pytest-%{python3_version} > > %endif > > I would recommend using the %pytest macro instead. > Thanks updated. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/python-meautility/python-meautility.spec SRPM URL: https://ankursinha.fedorapeople.org/python-meautility/python-meautility-1.4.8-1.fc33.src.rpm * Fri Nov 27 2020 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 1.4.8-1 - Remove docs: bundle fonts - Remove unneeded comments - Use pytest macro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
