https://bugzilla.redhat.com/show_bug.cgi?id=1902024 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> --- > This is a standard EPEL’ism, unfortunately; see https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL. I see, yes. Thanks for the link! > it was trying to install a Fedora 32 package into a Fedora 34/Rawhide root. No wonder it did not work! Any idea what caused this OS version mismatch? This one's on me. Apologies! I grabbed the wrong Koji build. > New Spec URL: https://gitlab.com/musicinmybrain/abseil-py-rpm/-/raw/9d4a6a4a/python-absl-py.spec > %package -n python3-%{srcname} > Summary: %{summary} > %if 0%{?fedora} < 33 > %py_provides python3-%{srcname} > %endif I would probably remove this check, since F33 is on its way out. > I think you have inadvertently convinced me that, for Python packages like this in particular, it would be better to submit a clean Fedora package, then introduce EPEL-specific cruft only in the relevant branches once the package is created, rather than littering the initial submission and the Fedora master with excessive conditionals. I think there are pros and cons to that. Would keeping the EPEL files in separate branches not make their git trees (EPEL7 and EPEL8) diverge from master and then require extra fiddling to keep the common bits in-sync with Fedora packages? On the other hand, it does make the SPEC files vastly more readable. > I guess the EPEL versions are now technically out of scope of the review, but you’re welcome to look over https://gitlab.com/musicinmybrain/abseil-py-rpm/-/raw/86f21d51bc792bc94e1ecd334f0b75cd829447f9/python-absl-py.spec, which works for both EPEL7 and EPEL8. Double-checked it with the extra EPEL guidelines and this looks good! I also haven't found any information on whether it's allowed or not to let Fedora and EPEL git trees diverge on purpose. >From my side the package is approved :). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
