https://bugzilla.redhat.com/show_bug.cgi?id=1902024 --- Comment #2 from code@xxxxxxxxxxxxxxxxxx --- > You can re-use URL in Source0 as %{url}. Good idea; done. > Is the %{python3_pkgversion} macro actually needed? Can these calls be replaced with simply python3-%{srcname} as is the case for the python2 packages? This is a standard EPEL’ism, unfortunately; see https://fedoraproject.org/wiki/PackagingDrafts:Python3EPEL. > Not sure about the use of %pyX_dist above. Would the format "pythonXdist(foo)" work in either/both cases? Yes, since there aren’t any modules with odd names for py3_dist to adjust, this would be fine. > What about using "%if 0%{?epel} > 7" as a condition? I know you're not technically targeting EPEL6, but... This would be OK, although it would have to be "%if 0%{?epel} > 7 || ! 0%{?epel}" to avoid catching Fedora. > - Package installs properly. > Note: Installation errors (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ Looking at the command that failed, > # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /data/rpmbuild/SPECS/python-absl-py/python3-absl-py-0.11.0-1.fc32.noarch.rpm --setopt=tsflags=nocontexts it was trying to install a Fedora 32 package into a Fedora 34/Rawhide root. No wonder it did not work! Any idea what caused this OS version mismatch? I think you have inadvertently convinced me that, for Python packages like this in particular, it would be better to submit a clean Fedora package, then introduce EPEL-specific cruft only in the relevant branches once the package is created, rather than littering the initial submission and the Fedora master with excessive conditionals. New Spec URL: https://gitlab.com/musicinmybrain/abseil-py-rpm/-/raw/9d4a6a4a/python-absl-py.spec New SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9640/56289640/python-absl-py-0.11.0-2.fc34.src.rpm New Koji builds: F34: https://koji.fedoraproject.org/koji/taskinfo?taskID=56289639 F33: https://koji.fedoraproject.org/koji/taskinfo?taskID=56289660 F32: https://koji.fedoraproject.org/koji/taskinfo?taskID=56289694 I guess the EPEL versions are now technically out of scope of the review, but you’re welcome to look over https://gitlab.com/musicinmybrain/abseil-py-rpm/-/raw/86f21d51bc792bc94e1ecd334f0b75cd829447f9/python-absl-py.spec, which works for both EPEL7 and EPEL8. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
