[Bug 1900181] Review Request: python-datrie - Efficiently stored Trie Data Structure for Python (uses libdatrie)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1900181



--- Comment #2 from Aniket Pradhan <aniketpradhan1999@xxxxxxxxx> ---
> Some of the lines are a little too long and rpmlint complains:
> python3-datrie.x86_64: E: description-line-too-long C trie variable is a
> dict-like object that can have unicode keys of certain ranges and Python
> objects as values.
> python3-datrie.x86_64: E: description-line-too-long C In addition to
> implementing the mapping interface, tries facilitate finding the items for a
> given prefix, and vice
> python3-datrie.x86_64: E: description-line-too-long C versa, finding the
> items whose keys are prefixes of a given string. As a common special case,
> finding the

Sure. I'll limit it to 80 characters.

> > I had to add in a small patch since the string decoding inside the module is by default for little-endian machines. Please refer to this [0] ticket for more info.
> 
> > # Patch to correctly decode on big/little endian systems
> > Patch0:			0001-BUG-Decode-string-based-on-byteorder-of-system.patch
> 
> If there is an open ticket somewhere, could you add it in a comment above
> the Patch0 line as well?

Will add that too ^.^

> Otherwise looks good. Approved! Full review below:

Thanks for your review!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux