https://bugzilla.redhat.com/show_bug.cgi?id=1900181 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Andy Mender <andymenderunix@xxxxxxxxx> --- > %global _description %{expand: > The library implements the Trie data structure. The trie variable is a > dict-like object that can have Unicode keys of certain ranges and Python > objects as values. > > In addition to implementing the mapping interface, the library tries to > facilitate finding the items for a given prefix, and vice versa, finding the > items whose keys are prefixes of a given string. As a common special case, > finding the longest-prefix item is also supported.} Some of the lines are a little too long and rpmlint complains: python3-datrie.x86_64: E: description-line-too-long C trie variable is a dict-like object that can have unicode keys of certain ranges and Python objects as values. python3-datrie.x86_64: E: description-line-too-long C In addition to implementing the mapping interface, tries facilitate finding the items for a given prefix, and vice python3-datrie.x86_64: E: description-line-too-long C versa, finding the items whose keys are prefixes of a given string. As a common special case, finding the > I had to add in a small patch since the string decoding inside the module is by default for little-endian machines. Please refer to this [0] ticket for more info. > # Patch to correctly decode on big/little endian systems > Patch0: 0001-BUG-Decode-string-based-on-byteorder-of-system.patch If there is an open ticket somewhere, could you add it in a comment above the Patch0 line as well? Otherwise looks good. Approved! Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Review: Internal to the package. No problem. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License (v2.1 or later)". 19 files have unknown license. Detailed output of licensecheck in /data/rpmbuild/SPECS/python-datrie/python-datrie/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-datrie Review: Looks bogus. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-datrie-0.8.2-1.fc34.x86_64.rpm python-datrie-debugsource-0.8.2-1.fc34.x86_64.rpm python-datrie-0.8.2-1.fc33.src.rpm python3-datrie.x86_64: W: spelling-error %description -l en_US trie -> tire, true, tie python3-datrie.x86_64: W: spelling-error %description -l en_US unicode -> Unicode, uni code, uni-code python3-datrie.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso python3-datrie.x86_64: E: description-line-too-long C trie variable is a dict-like object that can have unicode keys of certain ranges and Python objects as values. python3-datrie.x86_64: E: description-line-too-long C In addition to implementing the mapping interface, tries facilitate finding the items for a given prefix, and vice python3-datrie.x86_64: E: description-line-too-long C versa, finding the items whose keys are prefixes of a given string. As a common special case, finding the python-datrie.src: W: spelling-error %description -l en_US trie -> tire, true, tie python-datrie.src: W: spelling-error %description -l en_US versa -> avers, verse, verso python-datrie.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 24) 3 packages and 0 specfiles checked; 3 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name python3-datrie (none): E: no installed packages by name python-datrie-debugsource 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Unversioned so-files -------------------- python3-datrie: /usr/lib64/python3.9/site-packages/datrie.cpython-39-x86_64-linux-gnu.so Source checksums ---------------- https://files.pythonhosted.org/packages/source/d/datrie/datrie-0.8.2.tar.gz : CHECKSUM(SHA256) this package : 525b08f638d5cf6115df6ccd818e5a01298cd230b2dac91c8ff2e6499d18765d CHECKSUM(SHA256) upstream package : 525b08f638d5cf6115df6ccd818e5a01298cd230b2dac91c8ff2e6499d18765d Requires -------- python3-datrie (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python-datrie-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-datrie: python-datrie python3-datrie python3-datrie(x86-64) python3.9-datrie python3.9dist(datrie) python3dist(datrie) python-datrie-debugsource: python-datrie-debugsource python-datrie-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
