https://bugzilla.redhat.com/show_bug.cgi?id=1896742 --- Comment #4 from Andy Mender <andymenderunix@xxxxxxxxx> --- The SPEC file looks a lot better now! Good job! :) > BuildRequires: python3-devel > Requires: python3 > Requires: %{py3_dist pyusb} I think the last line should be: > Requires: python3dist(pyusb) Have a look at the related section in the Python Packaging Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies > %files -n python3-radexreader > %{python3_sitelib}/radexreader/ > %{python3_sitelib}/radexreader*egg-info/ > /lib/udev/rules.d/60-python3-radexreader.rules > %{_bindir}/radexreader You should also include the LICENSE file with the %license tag and the README.md file with the %doc tag. >From fedora-review: - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/rpmbuild/SPECS/python-radexreader/python-radexreader/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ I think there's been a mismatch between the upstream tarball and the sources used in the RPM and SRPM. >From rpmlint: > Rpmlint > ------- > Checking: python3-radexreader-1.0.0-1.fc32.noarch.rpm > python-radexreader-1.0.0-1.fc32.src.rpm > python3-radexreader.noarch: I: enchant-dictionary-not-found fr You need to add a BuildRequires on aspell-fr or hunspell-fr for the extra language checks to work properly. > python3-radexreader.noarch: W: no-documentation > python3-radexreader.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/radexreader/__init__.py 644 /usr/bin/python3 You should remove the "/usr/bin/python3" shebang from that file, for instance using "sed". Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /data/rpmbuild/SPECS/python-radexreader/python-radexreader/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License", "GNU General Public License". Detailed output of licensecheck in /data/rpmbuild/SPECS/python-radexreader/python- radexreader/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /lib/udev, /lib/udev/rules.d Review: bogus [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.8, /usr/lib/python3.8/site-packages, /lib/udev/rules.d, /lib/udev Review: bogus as well [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /data/rpmbuild/SPECS/python- radexreader/python-radexreader/srpm-unpacked/python-radexreader.spec See: (this test has no URL) Installation errors ------------------- INFO: mock.py version 2.6 starting (python version = 3.8.6)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.6 INFO: Mock Version: 2.6 Finish: chroot init INFO: installing package(s): /data/rpmbuild/SPECS/python-radexreader/python3-radexreader-1.0.0-1.fc32.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /data/rpmbuild/SPECS/python-radexreader/python3-radexreader-1.0.0-1.fc32.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python3-radexreader-1.0.0-1.fc32.noarch.rpm python-radexreader-1.0.0-1.fc32.src.rpm python3-radexreader.noarch: I: enchant-dictionary-not-found fr python3-radexreader.noarch: W: no-documentation python3-radexreader.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/radexreader/__init__.py 644 /usr/bin/python3 python3-radexreader.noarch: W: no-manual-page-for-binary radexreader 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Source checksums ---------------- https://github.com/luigifab/python-radexreader/raw/v1.0.0/debian/udev : CHECKSUM(SHA256) this package : fb5279baa7aa4962667705fbb42dbfd0ea45ef574a3f53c02a6ca14fc3e9f150 CHECKSUM(SHA256) upstream package : fb5279baa7aa4962667705fbb42dbfd0ea45ef574a3f53c02a6ca14fc3e9f150 https://github.com/luigifab/python-radexreader/releases/download/v1.0.0/python-radexreader-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 6d55312383b536777eb0db35864c96669e1ae6749487d6e5e9ba4a3c521e3679 CHECKSUM(SHA256) upstream package : f5b9922fbceb9dae5946649caac5a076e72e4364d9cc49b62452d7a959294cfd diff -r also reports differences Requires -------- python3-radexreader (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.8dist(pyusb) Provides -------- python3-radexreader: python-radexreader python3-radexreader python3.8dist(radexreader) python3dist(radexreader) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
