[Bug 1898312] Review Request: jakarta-jsonp - Jakarta JSON Processing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1898312

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I might be able to help here.

- The actual maven artifacts are named "jakarta.json" so I would suggest to
name the package "jakarta-json", which is similar to what we have done for the
other new "jakarta-*" packages. The GitHub repositories often have a weird /
non-matching / historical name that does no longer match the actual module
names.

- I see you stuck to the 1.1.6 release for now, which I would have done too.
The Latest x.0.0 releases are part of the Jakarta EE 9 release and should
probably be updated together (see the tasks on the java-maint-sig kanban board
for an overview). If it helps getting the package to build without the
eclipse-ee4j parent, you could even stick to 1.1.5 if that's not broken.

- I suspect the "-r" flag for "%pom_remove_plugin" does not work as expected
because the submodules are not declared at the toplevel, but only for certain
"profiles". I would suggest to patch the toplevel pom.xml file to include the
modules you want to build to the top level (instead of being only in certain
profiles).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux