Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tomsfastmath - A fast public domain, open source, large integer arithmetic library https://bugzilla.redhat.com/show_bug.cgi?id=253322 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-07 21:04 EST ------- I just did a quick build of this and found some issues: The debuginfo package seems broken; it doesn't contain any source. The proper set of CFLAGS aren't used. You can get them in with export CFLAGS="%{optflags}" at the very beginning of %build, but that still doesn't solve the broken debuginfo problem. Plus this package adds some additional options like -O3 which are generally frowned upon. Setting IGNORE_SPEED does get rid of those, but of course you should benchmark to see if it actually makes a difference. The -devel package doesn't own /usr/include/tomsfastmath/. It would be nice to package the changes.txt file as documentation, probably in the -devel package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review