Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: preload-0.4 - Preload is an adaptive readahead daemon https://bugzilla.redhat.com/show_bug.cgi?id=333491 ------- Additional Comments From kevin@xxxxxxxxx 2007-11-07 20:42 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 9c98bc97ec261925c9a40e5084c9c149 preload-0.4.tar.gz 9c98bc97ec261925c9a40e5084c9c149 preload-0.4.tar.gz.1 OK - BuildRequires correct See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. For your Source0: line use the http://downloads.sourceforge.net/... url as mentioned in: http://fedoraproject.org/wiki/Packaging/SourceURL 2. Can you add %{?_smp_mflags} to your make line? If that causes build problems please add a comment that it's disabled for that reason. 3. Why the "%verify(not md5 size mtime)" on your config files? Also, why %ghost on the state and log file? 4. You need some Requires because you have an init script. Take a look at: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-a6d7a1ed9d77dbb8d4af067378a79b838aebb20a 5. rpmlint says: preload.x86_64: E: non-standard-dir-perm /usr/share/doc/preload-0.4 0644 That dir should be 755... This is likely due to your "%defattr(-,root,root,0644)". That should be "%defattr(-,root,root,-)" preload.x86_64: W: service-default-enabled /etc/rc.d/init.d/preload preload.x86_64: W: service-default-enabled /etc/rc.d/init.d/preload It's discouraged to default enable a service. Do you think this one should be default enabled? 6. Since you have a logrotate file, should "Requires: logrotate" ? 7. Not a blocker, but something to note: Upstream hasn't released a new version since 2006. Is upstream dead? Are you willing to provide security fixes, etc? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review