https://bugzilla.redhat.com/show_bug.cgi?id=1895150 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #1) > (relevant) rpmlint output: > rubiks.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/rubiks/cu2-readme.txt > rubiks.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/rubiks/mcube-readme.txt > > Please fix. I actually had a sed invocation in %prep to do this, but managed to typo it. Fixed. > I think you might have mixed up Michael Reid's and Eric Dietz's code. Yes, I sure did. Good catch! Fixed. > Also, you could run some of the programs as a basic sanity check in %check, > e.g.: > %check > for v in cu2 cubex mcube ; do > echo | rubiks_${v} random > done Done. Thank you very much for the review. This is what I will actually import into git: Spec URL: https://jjames.fedorapeople.org/rubiks/rubiks.spec SRPM URL: https://jjames.fedorapeople.org/rubiks/rubiks-20070912-2.fc34.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
