https://bugzilla.redhat.com/show_bug.cgi?id=1895150 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review+ --- Comment #1 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- koji scratch build succeeds: https://koji.fedoraproject.org/koji/taskinfo?taskID=55032911 (relevant) rpmlint output: rubiks.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rubiks/cu2-readme.txt rubiks.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/rubiks/mcube-readme.txt Please fix. Are you sure that Michael Reid's code is under GPL+? reid/license.txt has the following statement: # Distributed under the terms of the GNU General Public License # (GPL), version 2 or later. I think you might have mixed up Michael Reid's and Eric Dietz's code. The latter has the following in license.txt: "They are, for the moment, released GPL" Other than that, this looks good, so APPROVED. Also, you could run some of the programs as a basic sanity check in %check, e.g.: %check for v in cu2 cubex mcube ; do echo | rubiks_${v} random done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
