https://bugzilla.redhat.com/show_bug.cgi?id=1885495 Dinesh <dineshx.balakrishnan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(carl@xxxxxxxxxx) | |needinfo?(carl@xxxxxxxxxx) --- Comment #13 from Dinesh <dineshx.balakrishnan@xxxxxxxxx> --- Hello @carl@xxxxxxxxxx, We have addressed most of the review comments. I have ran against different targets mentioned by you and below are my observations. qatlib is failed to build in many of the target and succeeded only in 'centos-stream-x86_64' and 'fedora-rawhide-x86_64'. Hence, qatengine able to build successfully only in this two target. qatlib build(failing in many target) : https://copr.fedorainfracloud.org/coprs/dineshbx/qatengine/build/1745585/ qatengine build: https://copr.fedorainfracloud.org/coprs/dineshbx/qatengine/build/1745663/ SRPM: https://copr-be.cloud.fedoraproject.org/results/dineshbx/qatengine/fedora-rawhide-x86_64/01745663-qatengine/qatengine-0.6.1-1.fc34.src.rpm SPEC: https://copr-be.cloud.fedoraproject.org/results/dineshbx/qatengine/fedora-rawhide-x86_64/01745663-qatengine/qatengine.spec - We will take care of removing the ./autogen.sh script and include 'autoreconf -vif' in next release into github. - In %install, we have only 5 lines. Hope it should be reasonable. Please review the SPEC file and let us know if anything needs to be corrected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
