https://bugzilla.redhat.com/show_bug.cgi?id=1885495 --- Comment #12 from Carl George 🤠 <carl@xxxxxxxxxx> --- Thank you for attempting to build this in copr. I can point the review tool directly at a copr build to automate many of the required checks. However, there are two problems with copr build 1715062. 1. It was only built against the fedora-31-x86_64 target. Reviews should be done against a Rawhide build. Since copr allows you to build against multiple targets, I suggest also building for CentOS Stream and ELN to ensure the package builds cleanly for EL8 and EL9. Change the settings of the copr to enable all of these targets: - centos-stream-aarch64 - centos-stream-x86_64 - fedora-eln-aarch64 - fedora-eln-s390x - fedora-eln-x86_64 - fedora-rawhide-aarch64 - fedora-rawhide-s390x - fedora-rawhide-x86_64 2. It failed to build because qatlib is not available. The reason I suggested building in copr was because it would allow you to build qatlib and qatengine together prior to qatlib being included in Fedora. You can get the qatlib SRPM from bug 1885430 and rebuild it first in the copr so that qatlib-devel is available to the qatengine build. I went ahead and did a quick look over of the spec file, and here are some things I noticed that need to be fixed. - The license header is still there. - Remove all instances of `(R)` from the Summary field and the %description section [0]. - Remove the last sentence from the %description. It is redundant because the URL is already included in the package metadata. - Source0 is not following the recommended format [1]. It should look like this: https://github.com/intel/%{githubname}/archive/v%{version}/%{name}-%{version}.tar.gz - Build requiring openssl-devel and qatlib-devel is sufficient. The build requirements for openssl and qatlib are redundant. - Missing build requirements for autoconf, automake, and libtool. - The machinery in autogen.sh seems unnecessary. In general running shell scripts during an rpm build should be avoided. Can the files in the .tools directory be moved to the top level? Then you can avoid the script and just run `autoreconf -vif` directly. Also, this should happen in %build, not %prep. - There is a lot going on during %install. Is there a Makefile target we could use instead to improve spec file legibility [2]? - The %ldconfig_scriptlets macro should be removed. This happens automatically [3]. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_trademarks_in_summary_or_description [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
