https://bugzilla.redhat.com/show_bug.cgi?id=1892101 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #12 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Spec URL: https://salimma.fedorapeople.org/specs/devel/fbthrift.spec SRPM URL: https://salimma.fedorapeople.org/specs/devel/fbthrift-2020.10.26.00-3.fc33.src.rpm fbthrift-devel now conflicts with thrift-devel, and addressed the RPATH issue. Note: there's a new version of fbthrift out today, but I'm not rebasing yet in case it wouldn't work with the folly/fizz/wangle builds from last week. I'll rebase them all after this is approved. specs on master [!?] ❯ rpmlint /var/lib/mock/fedora-rawhide-x86_64-fbthrift/result/fbthrift-2020.10.26.00-3.fc34.x86_64.rpm fbthrift.x86_64: W: shared-lib-calls-exit /usr/lib64/libcompiler_base.so.2020.10.26.0 exit@GLIBC_2.2.5 fbthrift.x86_64: W: no-documentation fbthrift.x86_64: W: no-manual-page-for-binary thrift1 1 packages and 0 specfiles checked; 0 errors, 3 warnings. (In reply to Neal Gompa from comment #11) > Review notes: > > > [!]: Rpath absent or only used for internal libs. > > Note: See rpmlint output > > There's some cleanup that needs to be done here, the rpath settings are > completely superfluous and could cause issues in some circumstances. > Fixed > > [!]: Package does not own files or directories owned by other packages. > > Note: Dirs in package are owned also by: /usr/include/thrift(thrift- > > devel) > > This requires a "Conflicts: thrift-devel" on the devel subpackage. > > > [!]: Package does not generate any conflict. > > See above. Fixed > > > [...] undefined-non-weak-symbol [...] > > I don't know what's going on here, but something is obviously wrong with how > this is getting built... Turns out to be related to the first RPATH problem. CMakeLists.txt specifies an incorrect RPATH so /usr//usr/lib64 ended up embedded in the shared libraries, which is obviously wrong. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
