[Bug 1892101] Review Request: fbthrift - Facebook's branch of Apache Thrift, including a new C++ server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1892101



--- Comment #11 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Review notes:

> [!]: Rpath absent or only used for internal libs.
>      Note: See rpmlint output

There's some cleanup that needs to be done here, the rpath settings are
completely superfluous and could cause issues in some circumstances.

> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by: /usr/include/thrift(thrift-
>      devel)

This requires a "Conflicts: thrift-devel" on the devel subpackage.

> [!]: Package does not generate any conflict.

See above.

> [!]: Package should compile and build into binary rpms on all supported
>      architectures.

This is known and documented, so this is fine.

> [...] undefined-non-weak-symbol [...]

I don't know what's going on here, but something is obviously wrong with how
this is getting built...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux