[Bug 1887470] Review Request: libtraceevent - library to parse raw trace event formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1887470



--- Comment #3 from Zamir SUN <sztsian@xxxxxxxxx> ---
(In reply to Jiri Olsa from comment #2)
> > [ ]: Package does not own files or directories owned by other packages.
> >      Note: Dirs in package are owned also by:
> >      /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(perf,
> >      trace-cmd-libs), /usr/lib64/traceevent/plugins(perf, trace-cmd-libs)
> > 
> > This is intended. The aim of the upstream traceevent is to make this a
> > shared library to be consumed by perf, trace-cmd and others. I'm also the
> > trace-cmd packager and working on solving the dependency after this library
> > is in Fedora. The perf part will be ready when it's done in upstream kernel
> > repo.
> 
> so what's the plan in here?
> start with libtracevent and perf as conflict packages 
> and then remove those plugins from perf rpm?
> 
> if that's the plan maybe we could ake this conflict
> explicit, I think there's 'Conflicts:' for that
> 

Hi Jiri,

Do you happen to know the plan of perf consuming libtraceevent upstream? If
there is a clear plan I think it worth mark a conflict with version
requirement. Otherwise I can add a general "Conflicts: perf" in the spec file.

> 
> other note:
> 
>  - package version and the library version do not match,
>    %{_libdir}/libtraceevent.so.1.1.0
>       vs
>    Version: 0
>    Release: 0.1.%{commitdate}git%{shortcommit}%{?dist}
> 
>    might be good to put version values to variables,
>    so you'll update only one place during the rpm update
> 

Ok, sure. While I think this is from the SRPM in comment 0. The version should
be in-sync in the version in comment 1 already.

I've updated both in-place without bump the release.

SPEC URL:
https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec
SRPM URL:
https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.0-1.fc34.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux