https://bugzilla.redhat.com/show_bug.cgi?id=1844120 --- Comment #19 from Iñaki Ucar <i.ucar86@xxxxxxxxx> --- Ah, ok, you need a sponsor. I see now that you have several review requests and you are working with Vasily to get sponsored. Great. Some comments about my spec with respect to yours. Note that: - I package the service file that comes under 'distributions', so that the program can be launched as a server by systemd. - I add the /var/log/jamulus folder for the log files that this service generates, including a logrotate file. - I use the %qmake_qt5 macro, which automatically sets up the required flags. - I use INSTALL_ROOT to be able to call %make_install without manually installing everything. - I generate a manpage with help2man. - I create some more icon sizes. Hope it helps. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
