https://bugzilla.redhat.com/show_bug.cgi?id=1883732 --- Comment #6 from Pavel Valena <pvalena@xxxxxxxxxx> --- Hello, sorry for the delay. Unfortunately, I forgot to continue to work on this, after getting initially stuck with the test suite. Now I was able to debug it, and all the tests pass. I've a also fixed the license for the font (interesting is that licensecheck didn't find it). Resulting in changes on top of original spec: https://git.io/JTiyQ Up-to-date Copr build (also has spec file): https://copr.fedorainfracloud.org/coprs/build/1722749 I've also run some automated checks: - Tests: ok - Syntax check: ok - Dependent packages: ok - Smoke test: ok - rpmlint: ok (false positives) _ _ _ _ Test log: cpr/rubygem-sassc-rails_test.log gem2rpm diff: cpr/rubygem-sassc-rails_gem2rpm.diff _ _ _ _ Additionaly: > * Weird RexExp > - The 'g' in the following RegExp is probably not needed, since you are matching single line anyway: Doesn't make much difference then? I'm used to write regexes like that... (removed) > * Test suite > - It seems you got completely drown. If you started with the rubygem-sass-rails, it would be easier. This is where I got: Yes, I was in a hurry to have it built :) ... (weird that I forgot afterwards). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
