[Bug 1885039] Review Request: python-dkimpy - DKIM, ARC, and TLSRPT email signing and verification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1885039

Andy Mender <andymenderunix@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> %description
> dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email signing and
> verification.

The first line of the %description is still too long. Try to split it like
this:
%description
dkimpy is a library that implements DKIM (DomainKeys Identified Mail) email 
signing and verification.

> %package -n     python3-%{pypi_name}
> Summary:        %{summary}
> %{?python_provide:%python_provide python3-%{pypi_name}}

Here, one should use the %py_provides macro:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro

You can do it on package import. The rest looks okay. Package approved!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux