https://bugzilla.redhat.com/show_bug.cgi?id=1887091 --- Comment #3 from Erich Eickmeyer <erich@xxxxxxxxxxxxxxxxxx> --- (In reply to leigh scott from comment #1) > 1: Remove > > BuildRequires: autoconf > > $ rpm -q --requires automake |grep auto > autoconf >= 2.65 Done > 2: You are running configure twice, change > > ./autogen.sh > > to > > NOCONFIGURE=1 ./autogen.sh Done > 3: You haven't validated the desktop file > > %{_datadir}/applications/jack_mixer.desktop > > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_desktop_file_install_usage Done > 4: Why two %doc?, change > > %doc README.md > %doc NEWS > > to > > %doc NEWS README.md I had been told one %doc per file before. > > 5: Remove > > Requires: jack-audio-connection-kit > > and > > Requires: python3 > > > Autorequires takes care of them As far as python3, sure, but I most certainly will not remove the jack-audio-connection-kit line. What is happening is that Autorequires is making applications that are looking for jack-audio-connection-kit not actually do that, but look for the libjack.so.0. This is causing problems for applications transitioning to pipewire-jack, which has a Provides line for jack-audio-connection-kit that is not honored by packages relying on Autorequires. This is something that I'm going to be pushing for all packages that Require jack-audio-connection-kit to explicitly call it regarless of BuildRequires since it's causing problems for the Pipewire tranition. > > rpm -qp --requires > /home/leigh/rpmbuild/RPMS/x86_64/jack-mixer-13-1.fc33.x86_64.rpm |grep > libjack.so.0 > libjack.so.0()(64bit) > Exactly, we can't be looking for libjack.so.0. We must provide compatibility with pipewire-jack, and this shatters that. > and > > $ rpm -qp --requires > /home/leigh/rpmbuild/RPMS/x86_64/jack-mixer-13-1.fc33.x86_64.rpm |grep > /usr/bin/python3 > /usr/bin/python3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
