https://bugzilla.redhat.com/show_bug.cgi?id=1871157 --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Thanks! (In reply to Vít Ondruch from comment #5) > * Test suite > - There is not missing rubygem(contest) just proper load path [1]. To load > the `contest`, there have to be added `-Itest` specified. > And for loading rest of the Ronn, the load path has to be `-Ilib:test`. > - You also need a few BRs: > > ~~~ > BuildRequires: rubygem(kramdown) > BuildRequires: rubygem(mustache) > BuildRequires: rubygem(nokogiri) > BuildRequires: rubygem(test-unit) > ~~~ Yep, I did that, and the tests pass. > * Soft dependency on groff-base? > - The `Requires: groff-base` could be possibly changed to `Recommends`. > This could help if Ronn is used as Ruby library. OTOH, > if it is included into buildroot to generate documentation, the soft > dependency would not be installed and that could be annoying. > - Nevertheless, wouldn't it be better to use `Requires: %{_bindir}/groff` > instead? I changed it to /usr/bin/groff. I think this is not going to be used as a library much, and breaking the commandline use would be annoying. (I didn't use a macro in the build requires, because if this package was rebuilt with a different %_bindir, e.g. for a flatpak, we'd still want the original location for groff.) > ~~~ > %gemspec_remove_dep -g mustache "~> 0.7" > ~~~ Done. > * Use macros where appropriate > - Please use macros on places where `/usr/share/` is used ATM. Done. > * Keep license file in its original place? > - I typically keep the license file in its original place, but this might > be even better, so I'm just saying because I stumbled upon it. Done. > * Small typo in changelog > - s/get2rpm/gem2rpm/ Done. > * Shebang vs execute bit > - Not sure this is worth of fixing, but upstream report about the first > one would not hurt: > > ~~~ > *** WARNING: ./usr/share/gems/gems/ronn-ng-0.9.1/lib/ronn.rb is executable > but has no shebang, removing executable bit > mangling shebang in /usr/share/gems/gems/ronn-ng-0.9.1/bin/ronn from > /usr/bin/env ruby to #!/usr/bin/ruby > ~~~ I remove the bit now in %prep. .spec and .src.rpm updated in place. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
