https://bugzilla.redhat.com/show_bug.cgi?id=1871157 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Test suite - There is not missing rubygem(contest) just proper load path [1]. To load the `contest`, there have to be added `-Itest` specified. And for loading rest of the Ronn, the load path has to be `-Ilib:test`. - You also need a few BRs: ~~~ BuildRequires: rubygem(kramdown) BuildRequires: rubygem(mustache) BuildRequires: rubygem(nokogiri) BuildRequires: rubygem(test-unit) ~~~ * Soft dependency on groff-base? - The `Requires: groff-base` could be possibly changed to `Recommends`. This could help if Ronn is used as Ruby library. OTOH, if it is included into buildroot to generate documentation, the soft dependency would not be installed and that could be annoying. - Nevertheless, wouldn't it be better to use `Requires: %{_bindir}/groff` instead? * Changing gem version dependencies. - I prefer to remove/add specific versions with `%gemspec_{remove,add}_dep`. This gives me hint if the dependencies are changing. This way, I would be able to remove the lines in the future (https://github.com/apjanke/ronn-ng/pull/46), otherwise changes like this will go unnoticed. - Also, you are changing wrong .gemspec file. The right file will be modified if you drop the `-s %{gem_name}.gemspec`. - IOW, this and nothing else should be what you want to do: ~~~ %gemspec_remove_dep -g mustache "~> 0.7" ~~~ * Use macros where appropriate - Please use macros on places where `/usr/share/` is used ATM. * Keep license file in its original place? - I typically keep the license file in its original place, but this might be even better, so I'm just saying because I stumbled upon it. * Small typo in changelog - s/get2rpm/gem2rpm/ * Shebang vs execute bit - Not sure this is worth of fixing, but upstream report about the first one would not hurt: ~~~ *** WARNING: ./usr/share/gems/gems/ronn-ng-0.9.1/lib/ronn.rb is executable but has no shebang, removing executable bit mangling shebang in /usr/share/gems/gems/ronn-ng-0.9.1/bin/ronn from /usr/bin/env ruby to #!/usr/bin/ruby ~~~ [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_minitest_testunit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
