https://bugzilla.redhat.com/show_bug.cgi?id=1879291 --- Comment #6 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "*No copyright* BSD 3-clause "New" or "Revised" License", "Apache License (v2.0)", "Expat License BSD 3-clause "New" or "Revised" License", "Expat License Apache License (v2.0)", "Expat License". 1463 files have unknown license. [X]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Nitpick here: Licensing breakdown could be more specific. [?]: Package contains no bundled libraries without FPC exception. There are some files with which have a license somewhere in the middle and they mention other libraries there. For example on bokeh/server/static/js/bokeh-widgets.legacy.js I see: 535: /* flatpickr/dist/flatpickr.js */ function _(require, module, exports) { /* flatpickr v4.6.3, @license MIT */ I am not very familiar with javascript code. Would flatpickr in this case be considered a bundled library? [X]: Changelog in prescribed format. Nitpick: Increment the release or place the second changelog entry within the first. It's more for consistency and not having two changelog entries with the same version/release. But this is more of a cosmetic change, not a blocker. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [-]: Package consistently uses macros (instead of hard-coded directory names). [?]: Package is named according to the Package Naming Guidelines. The package provides a binary as well. If its primary purpose is to utilize the binary and use the package as an application, then the name 'bokeh' instead of 'python-bokeh' would be more appropriate. If its main purpose is to be used as a library then it would be the other way around. What would be then its primary usage? [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-bokeh-2.2.1-1.fc34.noarch.rpm python-bokeh-2.2.1-1.fc34.src.rpm python3-bokeh.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases python3-bokeh.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/bokeh/server/static/.keep python3-bokeh.noarch: E: zero-length /usr/lib/python3.9/site-packages/bokeh/server/static/.keep python3-bokeh.noarch: W: no-manual-page-for-binary bokeh python-bokeh.src: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases 2 packages and 0 specfiles checked; 1 errors, 4 warnings. There is an empty .keep file for some reason Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. python3-bokeh.noarch: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases python3-bokeh.noarch: W: invalid-url URL: https://github.com/bokeh/bokeh <urlopen error [Errno -3] Temporary failure in name resolution> python3-bokeh.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/bokeh/server/static/.keep python3-bokeh.noarch: E: zero-length /usr/lib/python3.9/site-packages/bokeh/server/static/.keep python3-bokeh.noarch: W: no-manual-page-for-binary bokeh 1 packages and 0 specfiles checked; 1 errors, 4 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/b/bokeh/bokeh-2.2.1.tar.gz : CHECKSUM(SHA256) this package : a82e9eebd7a1e2ebb7f8fc1ead802fefd10a84daef8ec4bfc986121323948555 CHECKSUM(SHA256) upstream package : a82e9eebd7a1e2ebb7f8fc1ead802fefd10a84daef8ec4bfc986121323948555 Requires -------- python3-bokeh (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.9dist(jinja2) python3.9dist(numpy) python3.9dist(packaging) python3.9dist(pillow) python3.9dist(python-dateutil) python3.9dist(pyyaml) python3.9dist(setuptools) python3.9dist(tornado) python3.9dist(typing-extensions) Provides -------- python3-bokeh: python-bokeh python3-bokeh python3.9-bokeh python3.9dist(bokeh) python3dist(bokeh) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1879291 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: fonts, Java, SugarActivity, R, Haskell, Ocaml, Perl, C/C++, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Also why is the usr/bin/env shebang removal line in the SPEC? I didn't find any python shebangs within the project. Is it for future proofing in the case they appear at some point? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
