https://bugzilla.redhat.com/show_bug.cgi?id=1878898 Bob Hepple <bob.hepple@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob.hepple@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Bob Hepple <bob.hepple@xxxxxxxxx> --- Hi Aleksei, I'm afraid that the construct: BuildRequires: cmake(nlohmann_json) ... has thrown me!! I can see many similar constructs in Fedora spec files so I'm sure it must be legal, but the packaging guidelines don't document it (I'm looking at https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/) and I can't google anything about buildrequires: cmake(...) So I understand there is a subproject https://github.com/nlohmann/json package and the code is included in the nwg-launchers tarball. So far so good. But my local rpmbuild isn't able to grok it: $ rpmbuild -ba nwg-launchers.spec setting SOURCE_DATE_EPOCH=1600041600 error: Failed build dependencies: cmake(nlohmann_json) is needed by nwg-launchers-0.3.3-0.1.fc31.x86_64 I'd like to understand this as it's something I could use in my own packaging - in the past I have had to create separate discrete packages in this situation - so can you please point me at the doco for the Buildrequires: cmake(...) construct? 2/ The license for the nlohmann stuff is MIT so please reflect that in the spec file with an appropriate comment eg: # the subproject 'nlohmann' is licensed as MIT: License: GPLv3+ and MIT 3/ The file subprojects/nlohmann_json/third_party/cpplint/LICENSE indicates google licensing... I can't spot what name this is licensed as (on https://fedoraproject.org/wiki/Licensing) but it does require that the copyright notice be included with an appropriate comment in the spec file. 4/ The file subprojects/nlohmann_json/include/nlohmann/thirdparty/hedley/hedley.hpp is marked CC0-1.0. Please add it to the list of licenses if the code is included in the rpm with an appropriate comment in the spec file. 5/ The file subprojects/nlohmann_json/mark/src/complexity.h is marked Apache License, Version 2.0. Please add it to the list of licenses if the code is included in the rpm with an appropriate comment in the spec file. 6/ I'm assuming that the code in subprojects/nlohmann_json/benchmarks is not included in the final rpm 7/ how would you feel about adding the following to the description (or paraphrasing it): it must work well on sway; it should work as well as possible on Wayfire, i3, dwm and Openbox. ... I think it could be useful to a potential installer. Thanks Bob -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
