https://bugzilla.redhat.com/show_bug.cgi?id=1862842 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Andy Mender <andymenderunix@xxxxxxxxx> --- > The easiest thing to do for the xpm library is delete the bundled library and use the system library in its place. I now have that working. Awesome! > I could move icall.h to a -devel subpackage, but it would be the only file in that subpackage, which is why I hadn't done that. If you really think that's the right thing, I'll do it. I had a look at the icall.h header. I don't think it's worth creating a separate -devel package. You can keep it in the main package. Also, correct me if I'm wrong, but it's needed by the main Icon binary itself, right? As for versioning of the SO file, if the shared library is internal to Icon, it doesn't need to be versioned. There was a new release recently: https://github.com/gtownsend/icon/releases/tag/v9.5.20i Could you bump the version in the SPEC file accordingly? :) Other than that, package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
