https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - This won't be approved because Py 2 but still some remarks: %{?systemd_requires} → BuildRequires: systemd-rpm-macros - %{__python2} setup.py build → %py2_build - %{__python2} setup.py install --prefix=usr -O1 --skip-build --root $RPM_BUILD_ROOT → %py2_install - In any case don't mix $RPM_BUILD_ROOT and %{buildroot} - Not needed %defattr(-,root,root) %clean rm -rf $RPM_BUILD_ROOT - It is forbidden to glob the entire %{python2_sitelib}/ directory, be more specific instead. - You must install the LICENSE.txt with %license in %files - Source0: must either be a URL or you need to specify how to build the Source - Add your own changelog entry Maybe try targetinng EPEL7 (I don't know the status of Python 2 in EPEL8) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
