https://bugzilla.redhat.com/show_bug.cgi?id=1872427 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Group: System Environment/Daemons >[...] >%clean Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >License: Apache 2.0 Fedora uses the "ASL 2.0" short name for this licence. https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses >Source0: ec2-hibinit-agent-%{version}.tar.gz Ideally, this should be a downloadable URL. In case that's not possible, a comment explaining how the tarball was created is highly recommended, for the sake of reproducibility. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ >BuildRequires: python2 python2-devel Python2 is considered deprecated, to bring any new software depending on Python2 into Fedora you'll need an exception from the Engineering Steering Committee. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_version_support >%{__python2} setup.py install --prefix=usr -O1 --skip-build --root $RPM_BUILD_ROOT Why not just specify %{buildroot} as the --root, instead of installing to $RPM_BUILD_ROOT and then manually copying files? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
