[Bug 1871171] Review Request: python-RPi-GPIO2 - A libgpiod compatibility layer for the RPi.GPIO API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1871171

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
Source0:
https://github.com/underground-software/RPi.GPIO2/archive/v0.3.0a3.tar.gz

→

Source0:
https://github.com/underground-software/RPi.GPIO2/archive/v%{version}a3/%{name}-%{version}a3.tar.gz

 -

Version: 0.3.0
Release: 1%{?dist}

→

Version: 0.3.0
Release: 1.a3%{?dist}

 - This is not needed for a noarch package:

# This package is pure python code so debuginfo is useless
%global debug_package %{nil}

Just move:

BuildArch: noarch

to the main package.

 - Do this at the end of install:

rm -rf %{buildroot}%{python3_sitelib}/examples
rm -rf %{buildroot}%{python3_sitelib}/tests

 - As far as I understand, it needs to run on RPi to do the tests.

 - Don't mix tabs and spaces

 - Won't there be an import clash? One is in sitelib, the other in sitearch,
but if I import the package, which one will be loaded? Shouln't you change the
name of derectories to GPIO2?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux