https://bugzilla.redhat.com/show_bug.cgi?id=1871171 Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@xxxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- Just some comments: - The package should be named "python-rpi-gpio2" not "python-RPi-GPIO2" - There is a mismatch between the releases (upstream is 0.3.0a3, package is 0.3.0 but 0.3.0a3 is used). - The source tarball contains tests. Run them in %check. - %check is for running tests and not maintenance. - Ship the examples as part of %doc or as a subpackage. The same applies for the documentation. - %{python3_sitelib}/RPi/ should be renamed. Looks like that there could be a naming clash if python-rpi-gpio is installed as well. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
