https://bugzilla.redhat.com/show_bug.cgi?id=1869270 --- Comment #5 from Mat Booth <mat.booth@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > > Huh, git archeaology reveals that more than 10 years ago this package used to ship the (CC-BY licensed) Subversion Book as documentation... The sub-package containing the book was obsoleted more than a decade ago and the license tag was never corrected. Amazing what a fresh pair of eyes can do for an old package... > > I do my best to unearth such tidbits :-) > > > Small nit-picks: > > - JavaHL is not included in the latest version (1.11.1 vs. 1.14.0) > - Fix pom xml "4.2.0 modelVersion" declarations no longer necessary: > > # Fix pom xml declarations > # PR sent upstream here: https://github.com/subclipse/subclipse/pull/138 > sed -i -e 's/4\.2\.0/4.0.0/g' {.,features,bundles}/pom.xml > > This PR has been merged, and the Change is Live in the packaged version :-) The PR was merged just a few hours ago (I only sent it yesterday) and is not yet available in any tagged release. The packaged version is subclipse 4.3.0 that was tagged in 2019. > > - no Javadocs built (are they not useful? hard to build? broken? not > important, but I thought I'd note their absence) > No, we don't build separate javadoc subpackages for Eclipse plug-ins. In general they are not libraries against which users should build applications, and in the cases they are, Eclipse plug-ins tend to ship their javadocs as an additional plug-in bundle that extends Eclipse's built-in help system. So we trust the upstream project to ship documentation bundles as necessary. > > 1) You can put the JavaHL update on your TODO list, and remove the no longer > necessary "4.2.0 pom modelVersion" fixes before importing the package. > I will investigate the javahl update. I don't recall if this just a case of "it was the latest version at the time" or if this specific version was chosen because it was a known-good version and other versions had problems (svnkit fell into this latter category). > > 2) ./subclipse-4.3.0/features/feature.subclipse/licenses/Ganymed.txt: Expat > License BSD 3-clause "New" or "Revised" License > Is this the license file for the Ganymed / trilead / jenkins SSH2 > implementation? It's not bundled in this package, so this can be ignored. > Right? > That's right. The convention is to ship license texts for all the third-party bundles they ship in their upstream update site for their plug-ins to work. Since RPM installs directly and third-party bundles are packaged separately, this can be ignored. > > Other than that: > > - latest version packaged (4.3.0) - JavaHL update pending? > - package builds and installs successfully on fedora rawhide > - license correct and break-down documented, texts shipped with %license > - appdata for plugin installed and validated > - jar files shipped with sources are removed in %prep > - %build and %install script look "interesting" but good otherwise > - correct ExcludeArch tag for Eclipse packages > - in general, conforms to Packaging Guidelines > > Package APPROVED. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
