https://bugzilla.redhat.com/show_bug.cgi?id=1869270 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Huh, git archeaology reveals that more than 10 years ago this package used to ship the (CC-BY licensed) Subversion Book as documentation... The sub-package containing the book was obsoleted more than a decade ago and the license tag was never corrected. Amazing what a fresh pair of eyes can do for an old package... I do my best to unearth such tidbits :-) Small nit-picks: - JavaHL is not included in the latest version (1.11.1 vs. 1.14.0) - Fix pom xml "4.2.0 modelVersion" declarations no longer necessary: # Fix pom xml declarations # PR sent upstream here: https://github.com/subclipse/subclipse/pull/138 sed -i -e 's/4\.2\.0/4.0.0/g' {.,features,bundles}/pom.xml This PR has been merged, and the Change is Live in the packaged version :-) - no Javadocs built (are they not useful? hard to build? broken? not important, but I thought I'd note their absence) 1) You can put the JavaHL update on your TODO list, and remove the no longer necessary "4.2.0 pom modelVersion" fixes before importing the package. 2) ./subclipse-4.3.0/features/feature.subclipse/licenses/Ganymed.txt: Expat License BSD 3-clause "New" or "Revised" License Is this the license file for the Ganymed / trilead / jenkins SSH2 implementation? It's not bundled in this package, so this can be ignored. Right? Other than that: - latest version packaged (4.3.0) - JavaHL update pending? - package builds and installs successfully on fedora rawhide - license correct and break-down documented, texts shipped with %license - appdata for plugin installed and validated - jar files shipped with sources are removed in %prep - %build and %install script look "interesting" but good otherwise - correct ExcludeArch tag for Eclipse packages - in general, conforms to Packaging Guidelines Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
