https://bugzilla.redhat.com/show_bug.cgi?id=1862626 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > Same issues here: > > - duplicate Provides in main and -devel package (may not be problematic, as > noted in other reviews) > - wrong file permission on executable (555 instead of 755) > - ldd fails to read /usr/lib64/ocaml/ppx_optcomp/ppx_optcomp.cmxs I don't understand why you are seeing wrong permissions. I'm not. In the dune source code, bin/install_uninstall.ml, the code that copies files into the install tree includes this: let copy_file ~src ~dst ~executable ~special_file ~package = let chmod = if executable then fun _ -> 0o755 else fun _ -> 0o644 In other words, permissions are 755 for executables and 644 for everything else. The spec file manually adds execute permissions to the cmxs (shared library) files. And that's exactly what I see after doing a mock build of this package. I do not see the wrong permissions you see. I am running mock directly, rather than via fedora-review. I wouldn't expect that to matter, but let me try the latter. I'll report back. > Also your rich dependencies won't work the way you expect them to. "and" is > the wrong operator, "with" is the correct one: Oh no! Thanks for the heads up. I'll have to fix that in a bunch of packages. Thanks for alerting me before the rot spread any further. > I assume you'll flip the "with test" bcond once the circular dependencies > are all packaged? That remains to be seen. We have to figure out a strategy for building OCaml packages that participate in circular dependencies. I've got some thoughts along those lines but need to flesh them out significantly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
