https://bugzilla.redhat.com/show_bug.cgi?id=1862626 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Same issues here: - duplicate Provides in main and -devel package (may not be problematic, as noted in other reviews) - wrong file permission on executable (555 instead of 755) - ldd fails to read /usr/lib64/ocaml/ppx_optcomp/ppx_optcomp.cmxs Also your rich dependencies won't work the way you expect them to. "and" is the wrong operator, "with" is the correct one: (ocaml-base-devel >= 0.14 and ocaml-base-devel < 0.15) → (ocaml-base-devel >= 0.14 with ocaml-base-devel < 0.15) (ocaml-stdio-devel >= 0.14 and ocaml-stdio-devel < 0.15) → (ocaml-stdio-devel >= 0.14 with ocaml-stdio-devel < 0.15) Basically, the "with" ensures that the *same* dependency must satisfy both requirements. *and* allows two different packages to satisfy the two requirements. I assume you'll flip the "with test" bcond once the circular dependencies are all packaged? Other than that, package looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
