[Bug 1867689] Review Request: slingshot - A Newtonian strategy game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1867689



--- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> ---
The font file still ends up at this location:
/usr/lib/python3.9/site-packages/slingshot/data/FreeSansBold.ttf

I think this line:
rm -f slingshot/data/FreeSansBold.ttf

should be changed to this and moved to the %prep phase:
%prep
%setup -q
%patch0 -p1

rm -f src/slingshot/data/FreeSansBold.ttf

%build
%py3_build

Tested it locally and it works. Here's the Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=49049591

The only problem is that the paths to this font file seem to be hard-coded and
the moment I remove it, this happens:
pygame 1.9.6
Hello from the pygame community. https://www.pygame.org/contribute.html
Traceback (most recent call last):
  File "/usr/bin/slingshot", line 58, in <module>
    class Game:
  File "/usr/bin/slingshot", line 64, in Game
    Settings.font = pygame.font.Font(get_data_path("FreeSansBold.ttf"), 14)
FileNotFoundError: [Errno 2] No such file or directory:
'/usr/lib/python3.8/site-packages/slingshot/data/FreeSansBold.ttf'

The sources seem to confirm it:
https://github.com/ryanakca/slingshot/blob/fe976c8c51634b593c14e0a535a6552a0be156cd/src/slingshot/settings.py#L74

Not sure whether even patching this out would do the trick. One would probably
need to discuss this with upstream.

Do you happen to know how this font file is licensed?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux