[Bug 1862618] Review Request: ocaml-ppx-cold - OCaml definition of [@@cold] attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1862618



--- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> ---
Thank you again, Jared!

(In reply to Jared Smith from comment #1)
> Package is APPROVED.  I'm not sure what the "This should never happen"
> warning
> in the OCaml section is about, however.

I have a vague memory of trying to figure that out once, after seeing it in an
OCaml package review.  The warning comes from
/usr/share/fedora-review/plugins/ocaml.py:

class OcamlCheckStaticLibs(OcamlCheckBase):
    """ Disable static lib checking, ocaml has an exception. """

    def __init__(self, checks):
        OcamlCheckBase.__init__(self, checks)
        self.automatic = True
        self.text = "This should never happen"
        self.deprecates.append("CheckStaticLibs")

    def run_on_applicable(self):
        self.set_passed(self.PASS)

I don't know what happens to trigger it, though.  Apparently something is going
wrong with checking for static libraries, but the nature of that something is a
mystery to me.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux