Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cdpr - Cisco Discovery Protocol Analyzer https://bugzilla.redhat.com/show_bug.cgi?id=355631 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-10-29 01:51 EST ------- 1) you should use Source URL as Source0: http://downloads.sf.net/sourceforge/%{name}/%{name}-%{version}.tar.gz 2) Not needed README.Win32 and INSTALL as %doc. Remove those files. 3) for fixing dos end of line you can simplify as only sed -i 's/\r//g' COPYING README -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review