https://bugzilla.redhat.com/show_bug.cgi?id=1862306 --- Comment #3 from Artur Iwicki <fedora@xxxxxxxxxx> --- >I would check whether it's not possible to rely on pkgconfig for some of these, replacing "foo-devel" with "pkgconfig(foo)". For packages which do not provide pkgconfig files one can still use "foo-devel". I haven't used pkgconfig for packaging so far, but I checked and it seems all of the dependencies provide pkgconfig files, so I switched them all. >The shared lib should probably be versioned since this is not a -devel package. I'm not too versed in CMake, but the impression I got from reading the CMakeLists.txt is that it builds a dynamic library containing most of the logic, whereas the "easyrpg-player" executable and the test runners are just thin wrappers around the lib. I modified the CMakeLists to build a static library instead. Both the player and the tests seem to run fine, and it gets rid of the .so file. spec: https://svgames.pl/fedora/easyrpg-player-0.6.2.1-3/easyrpg-player.spec srpm: https://svgames.pl/fedora/easyrpg-player-0.6.2.1-3/easyrpg-player-0.6.2.1-3.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=48868685 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
