https://bugzilla.redhat.com/show_bug.cgi?id=1862306 --- Comment #2 from Andy Mender <andymenderunix@xxxxxxxxx> --- Since it would be a real shame if this didn't go into the repos, I'll review it :). > # EasyRPG Player itself is GPLv3+. > [...] > # PicoJSON is used only for Emscripten builds (and unbundled before build). > # Dirent is used only for MS Windows builds (and unbundled before build). > License: GPLv3+ and BSD Really good job with the license split! > BuildRequires: fmt-devel > BuildRequires: freetype-devel > BuildRequires: liblcf-devel > BuildRequires: libpng-devel > BuildRequires: libsndfile-devel > BuildRequires: libvorbis-devel > BuildRequires: libxmp-devel > BuildRequires: mpg123-devel > BuildRequires: opusfile-devel > BuildRequires: pixman-devel > BuildRequires: SDL2-devel > BuildRequires: SDL2_mixer-devel > BuildRequires: speexdsp-devel > BuildRequires: wildmidi-devel > BuildRequires: zlib-devel I would check whether it's not possible to rely on pkgconfig for some of these, replacing "foo-devel" with "pkgconfig(foo)". For packages which do not provide pkgconfig files one can still use "foo-devel". > # The upstream CMakeLists.txt forgets to install this file. > install -m 755 -d %{buildroot}%{_libdir}/ > install -m 755 -p "%{__cmake_builddir}/libEasyRPG_Player.so" %{buildroot}%{_libdir}/ The shared lib should probably be versioned since this is not a -devel package. Other than that, everything's nice and clean. Complete review matrix below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages Review: mentioned in an earlier comment ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages Review: Koji build provided by the submitter [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License", "*No copyright* GPL (v3 or later)", "BSD 3-clause "New" or "Revised" License", "BSD 2-clause "Simplified" License", "GPL (v3 or later)", "FSF All Permissive License", "Boost Software License 1.0", "GNU Lesser General Public License", "GNU Free Documentation License (v1.2 or later)". 387 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/easyrpg-player/easyrpg- player/licensecheck.txt Review: ran licensecheck manually. The Boost-licensed file is a development file not included in the package: builds/cmake/Modules/FindSDL2.cmake: Boost Software License 1.0 [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. Review: Yes, the latest patch release. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Review: Koji build provided by the submitter. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: easyrpg-player-0.6.2.1-2.fc33.x86_64.rpm easyrpg-player-debuginfo-0.6.2.1-2.fc33.x86_64.rpm easyrpg-player-debugsource-0.6.2.1-2.fc33.x86_64.rpm easyrpg-player-0.6.2.1-2.fc33.src.rpm easyrpg-player.x86_64: E: invalid-soname /usr/lib64/libEasyRPG_Player.so libEasyRPG_Player.so easyrpg-player.x86_64: W: shared-lib-calls-exit /usr/lib64/libEasyRPG_Player.so exit@GLIBC_2.2.5 4 packages and 0 specfiles checked; 1 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: easyrpg-player-debuginfo-0.6.2.1-2.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name easyrpg-player-debugsource (none): E: no installed packages by name easyrpg-player (none): E: no installed packages by name easyrpg-player-debuginfo 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Unversioned so-files -------------------- easyrpg-player: /usr/lib64/libEasyRPG_Player.so Source checksums ---------------- https://github.com/EasyRPG/Player/archive/0.6.2.1/Player-0.6.2.1.tar.gz : CHECKSUM(SHA256) this package : 59ffaff8da684b3cc391ac7bff5b95ddab524896cfb732cc2a8ff193bbbec8ac CHECKSUM(SHA256) upstream package : 59ffaff8da684b3cc391ac7bff5b95ddab524896cfb732cc2a8ff193bbbec8ac Requires -------- easyrpg-player (rpmlib, GLIBC filtered): libEasyRPG_Player.so()(64bit) libSDL2-2.0.so.0()(64bit) libSDL2_mixer-2.0.so.0()(64bit) libWildMidi.so.2()(64bit) libc.so.6()(64bit) libfreetype.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) liblcf.so.0()(64bit) libm.so.6()(64bit) libmpg123.so.0()(64bit) libopusfile.so.0()(64bit) libpixman-1.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libspeexdsp.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libvorbisfile.so.3()(64bit) libxmp.so.4()(64bit) libxmp.so.4(XMP_4.0)(64bit) libxmp.so.4(XMP_4.1)(64bit) libxmp.so.4(XMP_4.3)(64bit) libxmp.so.4(XMP_4.4)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) easyrpg-player-debuginfo (rpmlib, GLIBC filtered): easyrpg-player-debugsource (rpmlib, GLIBC filtered): Provides -------- easyrpg-player: easyrpg-player easyrpg-player(x86-64) libEasyRPG_Player.so()(64bit) easyrpg-player-debuginfo: debuginfo(build-id) easyrpg-player-debuginfo easyrpg-player-debuginfo(x86-64) easyrpg-player-debugsource: easyrpg-player-debugsource easyrpg-player-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
