https://bugzilla.redhat.com/show_bug.cgi?id=1862660 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Where does it say the license is GPLv3+? The LICENSE file does contain the text of GPLv3, but the link in the "## License" section in README says the license is "GNU General Public License v3.0 only", which would be "GPLv3"; i.e., without the +. - Remove the times from %changelog. There are 3 changelog formats to choose from. All of them include the date only: https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/lib/systemd, /usr/lib/systemd/user [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in clash [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: clash-1.0.0-4.fc33.x86_64.rpm golang-github-dreamacro-clash-devel-1.0.0-4.fc33.noarch.rpm clash-1.0.0-4.fc33.src.rpm clash.x86_64: W: no-manual-page-for-binary clash golang-github-dreamacro-clash-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/Dreamacro/clash/.goipath 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: clash-debuginfo-1.0.0-4.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- clash.x86_64: W: no-manual-page-for-binary clash golang-github-dreamacro-clash-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/Dreamacro/clash/.goipath 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/Dreamacro/clash/archive/v1.0.0/clash-1.0.0.tar.gz : CHECKSUM(SHA256) this package : eefd9fb6c413a4eca7999eb4dd1d760a5bfd61100310390ba9c24b64f0962f28 CHECKSUM(SHA256) upstream package : eefd9fb6c413a4eca7999eb4dd1d760a5bfd61100310390ba9c24b64f0962f28 Requires -------- clash (rpmlib, GLIBC filtered): /bin/sh libc.so.6()(64bit) libpthread.so.0()(64bit) golang-github-dreamacro-clash-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/Dreamacro/go-shadowsocks2/core) golang(github.com/Dreamacro/go-shadowsocks2/shadowaead) golang(github.com/go-chi/chi) golang(github.com/go-chi/cors) golang(github.com/go-chi/render) golang(github.com/gofrs/uuid) golang(github.com/gorilla/websocket) golang(github.com/miekg/dns) golang(github.com/oschwald/geoip2-golang) golang(github.com/sirupsen/logrus) golang(golang.org/x/crypto/argon2) golang(golang.org/x/crypto/chacha20poly1305) golang(golang.org/x/net/publicsuffix) golang(golang.org/x/sync/singleflight) golang(gopkg.in/eapache/channels.v1) golang(gopkg.in/yaml.v2) Provides -------- clash: clash clash(x86-64) golang-github-dreamacro-clash-devel: golang(github.com/Dreamacro/clash/adapters/inbound) golang(github.com/Dreamacro/clash/adapters/outbound) golang(github.com/Dreamacro/clash/adapters/outboundgroup) golang(github.com/Dreamacro/clash/adapters/provider) golang(github.com/Dreamacro/clash/common/cache) golang(github.com/Dreamacro/clash/common/murmur3) golang(github.com/Dreamacro/clash/common/observable) golang(github.com/Dreamacro/clash/common/picker) golang(github.com/Dreamacro/clash/common/pool) golang(github.com/Dreamacro/clash/common/queue) golang(github.com/Dreamacro/clash/common/singledo) golang(github.com/Dreamacro/clash/common/sockopt) golang(github.com/Dreamacro/clash/common/structure) golang(github.com/Dreamacro/clash/component/auth) golang(github.com/Dreamacro/clash/component/dialer) golang(github.com/Dreamacro/clash/component/fakeip) golang(github.com/Dreamacro/clash/component/mmdb) golang(github.com/Dreamacro/clash/component/nat) golang(github.com/Dreamacro/clash/component/resolver) golang(github.com/Dreamacro/clash/component/simple-obfs) golang(github.com/Dreamacro/clash/component/snell) golang(github.com/Dreamacro/clash/component/socks5) golang(github.com/Dreamacro/clash/component/trie) golang(github.com/Dreamacro/clash/component/trojan) golang(github.com/Dreamacro/clash/component/v2ray-plugin) golang(github.com/Dreamacro/clash/component/vmess) golang(github.com/Dreamacro/clash/config) golang(github.com/Dreamacro/clash/constant) golang(github.com/Dreamacro/clash/dns) golang(github.com/Dreamacro/clash/hub) golang(github.com/Dreamacro/clash/hub/executor) golang(github.com/Dreamacro/clash/hub/route) golang(github.com/Dreamacro/clash/log) golang(github.com/Dreamacro/clash/proxy) golang(github.com/Dreamacro/clash/proxy/auth) golang(github.com/Dreamacro/clash/proxy/http) golang(github.com/Dreamacro/clash/proxy/mixed) golang(github.com/Dreamacro/clash/proxy/redir) golang(github.com/Dreamacro/clash/proxy/socks) golang(github.com/Dreamacro/clash/rules) golang(github.com/Dreamacro/clash/tunnel) golang-github-dreamacro-clash-devel golang-ipath(github.com/Dreamacro/clash) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1862660 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Haskell, R, C/C++, Ruby, Ocaml, Java, fonts, Python, SugarActivity, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
