[Bug 1862861] Review Request: golang-github-shulhan-bindata - A small utility which generates Go code from any file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1862861

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
To document what I said by mail:

> You did take care of all seven packages that I had.  However, I found
> out yesterday in testing that even though the cli package built, it was
> not functional.  The go-bindata part of prep failed silently and didn't
> build the code needed for the cli to actually function properly.  After
> a bit of research I found out that the go-bindata that we ship in F33
> and earlier has a dead upstream and a fork of the last state became the
> new upstream.  Looking at the old package, it doesn't come close to how
> the other go packages are created, so I decided to create a new review
> request for the new upstream:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1862861
> 
> I did add the obsoletes and provides as I *think* it should be.  If you
> do approve this approach and the package, I guess I'll need to reach out
> to the four maintainers of the package:
> 
> https://src.fedoraproject.org/rpms/go-bindata

I do not approve. The go-bindata repo is still maintained and active:
https://github.com/go-bindata/go-bindata/commits/master
Last release was in February, which very recent compared to most Go packages.
The Fedora package was not updated, its maintainers are not active anymore with
Go stuff for Fedora as far as I know.

This other fork has the same basis, the Jim Teeuwen go-bindata repo. Jim
Teeuwen has apparently disappeared and thus the project go-bindata/go-bindata
was created. Now both forks have strongly diverged, so one is no more valid or
the successor of the other, they are two projects sharing the same name from a
common ancestor.

> 
> and ask them to retire it?
> 

No, and you shouldn't Provides/Obsoletes the current go-bindata. Instead I
suggest that you prefix or postfix the conflicting binary (with shulhan or any
suffix you find appropriate).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux