[Bug 1376511] Review Request: nexus - NeXus scientific data file format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1376511



--- Comment #18 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> For the COPYING file, I wasn't sure if the file had to be 'installed' (hence the patch was to add that to CMake), but it looks like the %license macro picks it up from the source/build.

If it's in the root of the source dir, using %license for license files and
%doc for documentation files will add these to the correct directories :).

> Wasn't sure how bad the first one is, but the second one is a false warning, as muon is spelt correctly.

I think the first one is bogus as well. Don't worry about it.

Last things reported by rpmlint:

Rpmlint
-------
[...]
nexus.x86_64: E: incorrect-fsf-address /usr/share/licenses/nexus/COPYING
nexus-devel.x86_64: W: no-documentation
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napi.h
nexus-devel.x86_64: E: incorrect-fsf-address /usr/include/nexus/napiu.h
[...]
6 packages and 0 specfiles checked; 3 errors, 8 warnings.

A rather minor item, but I would add the COPYING file to the -devel package as
well:
%files devel
%license COPYING

As for the "incorrect-fsf-address" errors, the guidelines recommend contacting
upstream:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
I've personally never seen this before, but it's not a blocking issue either
way.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux