https://bugzilla.redhat.com/show_bug.cgi?id=1862305 --- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> --- > On one hand, yes, it could be named "easyrpg-liblcf" as it's closely related to that project. On the other hand, well, it's a library and can be used by other projects, so I'm not sure if "hiding" it behind the "easyrpg-" prefix makes sense. I agree it makes more sense to leave it as "liblcf" if it's not strictly tied to the rest of the easyrpg packages. > Oh, thanks. I took a better look and src/ini.{cpp,h} are actually a bundled library, "inih" (already packaged in Fedora). src/inireader.{cpp,h} are part of "example code" for that library. I un-bundled inih and added a comment explaining the licensing. Nice! > The last line is a file, not a directory. Added a file extension to make that more clear. My bad then. The asterisk at the end confused me a bit. > I took a better look at upstream's CMakeLists.txt and noticed that they auto-launch "update-mime-database" during install, and that's what generates those files. Disabled this. Can confirm they're gone. Great! I re-ran fedora-review and things look almost perfect now. However, I see rpmlint picked up a couple more things I missed last time: Rpmlint ------- Checking: liblcf-0.6.2-2.fc33.x86_64.rpm liblcf-devel-0.6.2-2.fc33.x86_64.rpm liblcf-debuginfo-0.6.2-2.fc33.x86_64.rpm liblcf-debugsource-0.6.2-2.fc33.x86_64.rpm liblcf-0.6.2-2.fc33.src.rpm liblcf.x86_64: W: no-documentation liblcf-devel.x86_64: W: no-documentation liblcf.src:51: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 51) # not sure where this comes from, since the SPEC file looks okay space/tab wise. 5 packages and 0 specfiles checked; 0 errors, 3 warnings. The main source dir contains a README.md file. I would include it in both the main and -devel subpackage with the %doc macro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
