https://bugzilla.redhat.com/show_bug.cgi?id=1862305 --- Comment #2 from Artur Iwicki <fedora@xxxxxxxxxx> --- >I see this package is related to the easyrpg project. Would it make sense to rename it to "easyrpg-liblcf"? On one hand, yes, it could be named "easyrpg-liblcf" as it's closely related to that project. On the other hand, well, it's a library and can be used by other projects, so I'm not sure if "hiding" it behind the "easyrpg-" prefix makes sense. >licensecheck reports the following as BSD-licensed: >liblcf-0.6.2/src/ini.cpp: BSD 3-clause "New" or "Revised" License >liblcf-0.6.2/src/ini.h: BSD 3-clause "New" or "Revised" License >liblcf-0.6.2/src/inireader.cpp: BSD 3-clause "New" or "Revised" License >liblcf-0.6.2/src/inireader.h: BSD 3-clause "New" or "Revised" License > >The License block should probably say "BSD and MIT" and in a comment above you can mention that src/ini.* and src/inireader.* files are BSD-licensed, since they're in minority. Oh, thanks. I took a better look and src/ini.{cpp,h} are actually a bundled library, "inih" (already packaged in Fedora). src/inireader.{cpp,h} are part of "example code" for that library. I un-bundled inih and added a comment explaining the licensing. >> %{_datadir}/mime/packages/%{name}* >The last line should say "%{_datadir}/mime/packages/%{name}/" if the package is supposed to own that directory. The last line is a file, not a directory. Added a file extension to make that more clear. >> %{_libdir}/cmake/%{name}/* >Should the package own the "%{_libdir}/cmake/%{name}/" dir? If so, remove the trailing asterisk. Good catch. >Also, rpmlint reports the following files as not associated with the package, yet installed: > /usr/share/mime/[...a lot of stuff here...] I took a better look at upstream's CMakeLists.txt and noticed that they auto-launch "update-mime-database" during install, and that's what generates those files. Disabled this. Updated links: spec: https://svgames.pl/fedora/liblcf-0.6.2-2/liblcf.spec srpm: https://svgames.pl/fedora/liblcf-0.6.2-2/liblcf-0.6.2-2.fc32.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=48382343 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
