Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gsl https://bugzilla.redhat.com/show_bug.cgi?id=225863 ------- Additional Comments From pertusus@xxxxxxx 2007-10-27 06:22 EST ------- (In reply to comment #22) > > And why do you remove the man pages? > gsl man-pages are not in a good state, so I think it is better to remove them at > all (there could be use documentation instead) Why aren't they in a good state? They seem perfect to me. I used the example in gsl-histogram and it looks like a Cauchy distribution. And the gsl.3 page is just a reference to other doc. > > I suggest replacing > > rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la > > with > > rm $RPM_BUILD_ROOT%{_libdir}/*.la > I prefer the present version. At least remove the -r, it doesn't make any sense. > > Only a suggestion, to keep the THANKS file timestamp, you can do > > touch -r THANKS THANKS.aux > > before mv. > I prefer the present version. Ok. But you should be aware than in a in a multiarch setting, a rpm -V will should wrong timestamp. In my opinion this is a sufficient reason to keep timestamps right for noarch files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review