Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gsl https://bugzilla.redhat.com/show_bug.cgi?id=225863 ------- Additional Comments From varekova@xxxxxxxxxx 2007-10-26 07:14 EST ------- Thanks. Fixed in gsl-1.10-6.fc9. >You should either have >%{_datadir}/aclocal > >or >%{_datadir}/aclocal/* >%dir %{_datadir}/aclocal Fixed. > And why do you remove the man pages? gsl man-pages are not in a good state, so I think it is better to remove them at all (there could be use documentation instead) > I suggest replacing > rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la > with > rm $RPM_BUILD_ROOT%{_libdir}/*.la I prefer the present version. > Only a suggestion, to keep the THANKS file timestamp, you can do > touch -r THANKS THANKS.aux > before mv. I prefer the present version. > Also it should be better to remove the .gz from install-info > scriptlets since install-info can detect itself if .gz is needed. > This is not a blocker, but I can't see why you shouldn't do it. Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review