Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Business-ISBN - Perl module to work with International Standard Book Numbers https://bugzilla.redhat.com/show_bug.cgi?id=351761 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 22:17 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 507f90ec2e8f53e138222895444cef4c Business-ISBN-2.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/albania................ok t/constants..............ok t/interface..............ok t/isbn10.................# # Checking ISBNs... (this may take a bit) # # Checking bad ISBNs... (this should be fast) ok t/isbn13.................# # Checking ISBN13s... (this may take a bit) # # Checking bad ISBN13s... (this should be fast) ok t/load...................ok t/png_barcode............ok t/pod....................ok t/pod_coverage...........ok t/valid_isbn_checksum....ok t/xisbn10................ok All tests successful. Files=11, Tests=142, 20 wallclock secs (14.53 cusr + 0.13 csys = 14.66 CPU) + Package perl-Business-ISBN-2.03-3.fc8-> Provides: perl(Business::ISBN) = 2.03 perl(Business::ISBN10) perl(Business::ISBN13) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Business::ISBN) perl(Business::ISBN10) perl(Business::ISBN13) perl(Business::ISBN::Data) >= 1.15 perl(Carp) perl(Data::Dumper) perl(base) perl(strict) perl(subs) perl(vars) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review