Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl-libxml-perl https://bugzilla.redhat.com/show_bug.cgi?id=226269 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 22:09 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0ed5fbdda53d1301ddaed88db10503bb libxml-perl-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/amsterdam...........ok t/canon_xml_writer....ok t/schema..............ok t/stream..............ok t/subs................ok t/xp_sax..............ok All tests successful. Files=6, Tests=45, 0 wallclock secs ( 0.28 cusr + 0.07 csys = 0.35 CPU) + Package perl-libxml-perl-0.08-3.fc8 -> Provides: perl(Data::Grove::Characters) perl(Data::Grove::Parent) = 0.08 perl(Data::Grove::ParentList) perl(Data::Grove::Visitor) = 0.08 perl(XML::ESISParser) = 0.08 perl(XML::Handler::CanonXMLWriter) = 0.08 perl(XML::Handler::Sample) perl(XML::Handler::Subs) = 0.08 perl(XML::Handler::XMLWriter) = 0.08 perl(XML::Parser::PerlSAX) = 0.08 perl(XML::PatAct::ACTION) perl(XML::PatAct::Amsterdam) = 0.08 perl(XML::PatAct::MatchName) = 0.08 perl(XML::PatAct::PATTERN) perl(XML::PatAct::ToObjects) = 0.08 perl(XML::Perl2SAX) = 0.08 perl(XML::SAX2Perl) = 0.08 Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::File) perl(UNIVERSAL) perl(XML::Handler::Subs) perl(XML::Parser) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review