[Bug 1858531] Review Request: partio - Library for reading/writing/manipulating common animation particle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1858531



--- Comment #7 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> ---
Thank you for the fix. The build is successful this time. 
I figured out some build requirements lack pkgconfig files on Fedora 31 when
testing the scratch build so I adjusted the condition.

(In reply to Robert-André Mauchin 🐧 from comment #6)
> libpartio-devel requires libpartio instead of the main package. You might
> need to adjust the Summary/Description to reflect what's actually packaged
> (i.e. main package containing the tools and libpartio containing the lib)
> 
> %files -n libpartio
> %license LICENSE
> %{_libdir}/*.so.1*

Is "%files lib" an equivalent partio-devel requires partio-lib? Some packages
used that method. 

>  - Also remove the tabs introduced in line 12, line 55, line 58

Fixed

>  - Do not use ExcludeArch but ExclusiveArch with the arches you support.

I find out it is unneeded.

Here is the updated files:

SPEC:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-32-x86_64/01563228-partio/partio.spec
SRPM:
https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/fedora-32-x86_64/01563228-partio/partio-1.10.1-3.fc32.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux