[Bug 1858531] Review Request: partio - Library for reading/writing/manipulating common animation particle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1858531



--- Comment #6 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
Fixed it.

diff -ru partio-1.10.1.orig/src/lib/CMakeLists.txt
partio-1.10.1/src/lib/CMakeLists.txt
--- partio-1.10.1.orig/src/lib/CMakeLists.txt   2019-07-10 19:11:02.000000000
-0700
+++ partio-1.10.1/src/lib/CMakeLists.txt        2020-07-18 20:50:13.713384480
-0700
@@ -35,7 +35,11 @@
 file(GLOB core_cpp "core/*.cpp")

 add_library(partio ${io_cpp} ${core_cpp})
-set_target_properties(partio PROPERTIES OUTPUT_NAME partio
POSITION_INDEPENDENT_CODE ON)
+set_target_properties(partio PROPERTIES 
+    OUTPUT_NAME partio POSITION_INDEPENDENT_CODE ON
+    VERSION ${CMAKE_PROJECT_VERSION}
+    SOVERSION 1 
+)

 target_include_directories(partio
     PUBLIC

================================================================

No the other issue I haven't mentioned yet is where to put the library we
created. I think it should ship separately into a libpartio subpackage and then
you change your devel package into libpartio-devel and make libpartio-devel
requires libpartio instead of the main package. You might need to adjust the
Summary/Description to reflect what's actually packaged (i.e. main package
containing the tools and libpartio containing the lib)

%files -n libpartio
%license LICENSE
%{_libdir}/*.so.1*

 - Also remove the tabs introduced in line 12, line 55, line 58

 - Do not use ExcludeArch but ExclusiveArch with the arches you support.

 -


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux