https://bugzilla.redhat.com/show_bug.cgi?id=1853888 --- Comment #10 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Lewis from comment #9) > Hi, > > I took Robert-André Mauchin's advices in account. > > Here is the new srpm and spec files : > https://copr-be.cloud.fedoraproject.org/results/lewisanesa/CodeColla/fedora- > 32-x86_64/01554976-LTK/LTK-1.6.3-14.fc32.src.rpm > https://copr-be.cloud.fedoraproject.org/results/lewisanesa/CodeColla/fedora- > 32-x86_64/01554976-LTK/LTK-1.6.3-14.spec > > Now it generates libLTK.so.1 and > libLTK.so -> libLTK.so.1 > libLTK.so.1.6.3 -> libLTK.so.1 > > But I still have three questions : > Why not do libLTK.so -> libLTK.so.1 -> libLTK.so.1.6.3 links? That's the same thing. The unversioned is a link which goes to the -devel subpackage though. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > Shouldn't my package be dependent of libunwind? what if libunwind evolves? Libraries deps are generated automatically. If libunwind is updated with a SONAME bump, your package will need to be recompiled. SONAME bump should be announced by the maintainer one week in advance through the devel mailing list. > How can I change the line "rpmbuild -D "_topdir $(pwd)" -ba $SPEC_FILE" > in order to use fedpkg or mock or whatever I have to use? Take a look at "man mock". You got examples at the bottom: mock -r fedora-rawhide-x86_64 --resultdir=./my-results /path/to/your.src.rpm > (This line is in the over engineered auto script make.sh at the root of > git://codecolla.com/libltk) > > I said : > > For non french speaking people, I'll recap changes made to fit fedora requirements, may this help someone one day... > > - Added a MAJOR global definition in the specfile > - Commented and corrected Source0 > - Added empty line management in dependencies > - Switched %prep to %autosetup > - Added intermediate shared object file with only major in name > - Added it to soname on gcc final output > - Gathered together install files and managed multi section manpages > - Added link layer to proper tarball creation > - Added fedora's compil flags > - Removed libunwind dependency (libunwind-devel build dep is enough) > - Added constant strings to sprintf calls (fedora flags compatibility) > Source0: SOURCES/%{name}-%{version}.tar.gz The sources should be in the same directory as your SPEC: Source0: %{name}-%{version}.tar.gz I'm doing some computation right now, I'll continue with fedora-review when I have more free CPU cycles. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
